[wp-trac] [WordPress Trac] #26343: has_shortcode not recognizing nested shortcodes

[WordPress Trac]

#26343: has_shortcode not recognizing nested shortcodes
---------------------------+-----------------------------
 Reporter:  sunyatasattva  |       Owner:  wonderboymusic
     Type:  defect (bug)   |      Status:  reopened
 Priority:  normal         |   Milestone:  4.0
Component:  Shortcodes     |     Version:  3.6
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+-----------------------------
Changes (by kovshenin):

 * keywords:  has-patch needs-unit-tests 2nd-opinion => has-patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Two things regarding r29197.

 First, `$shortcode[5]` is always set and sometimes empty, so the `isset`
 check is pretty useless here. Second, since we already call
 `has_shortcode()` in the elseif statement, we can safely return true
 without running it again. See [attachment:26343.2.diff].

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26343#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform