[wp-trac] [WordPress Trac] #28749: Unused variable $num_ratings in WP_Theme_Install_List_Table

WordPress Trac noreply at wordpress.org
Mon Jul 14 17:55:33 UTC 2014


#28749: Unused variable $num_ratings in WP_Theme_Install_List_Table
--------------------------+------------------------------
 Reporter:  Corphi        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Themes        |     Version:  3.8
 Severity:  trivial       |  Resolution:
 Keywords:                |     Focuses:
--------------------------+------------------------------
Changes (by DrewAPicture):

 * keywords:  close =>


Comment:

 Hi michalzuber,

 The filter doc currently lives in the file it was introduced for -- the
 second-usage in ajax-actions is merely a duplicate. It doesn't matter if
 the file is currently loaded or not, if it's still available in core, it's
 still the correct place to document that hook.

 -1 for [attachment:28749.2.diff]

 On track with the topic of this ticket, I can see applying
 [attachment:num_ratings.patch] as long as it doesn't create an issue
 elsewhere.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28749#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list