[wp-trac] [WordPress Trac] #23560: Keyboard Accessibility of Add Media Panel

[WordPress Trac]

#23560: Keyboard Accessibility of Add Media Panel
----------------------------+----------------------------
 Reporter:  grahamarmfield  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  Media           |     Version:  3.5.1
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  accessibility
----------------------------+----------------------------

Comment (by ericlewis):

 Not sure what the intent was with the code in the else block here:

 {{{
 #!javascript
 if ( 27 === event.which && this.$el.is(':visible') ) {
         this.escape();
         event.stopImmediatePropagation();
 } else {
         // Keep focus inside the media modal
         this.focusManager;
 }
 }}}

 but it doesn't invoke anything, just references the focusManager property.
 attachment:23560.11.diff removes it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23560#comment:72>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform