[wp-trac] [WordPress Trac] #28761: wpviews: gallery shortcodes displaying "undefined" for an instant

[WordPress Trac]

#28761: wpviews: gallery shortcodes displaying "undefined" for an instant
--------------------------+------------------
 Reporter:  avryl         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  4.0
Component:  TinyMCE       |     Version:  3.9
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+------------------

Comment (by azaozz):

 Replying to [comment:3 helen]:
 > I thought we had discussed a loading indicator at some point

 Right. In 28761.3.patch:
 - Add `loadingPlaceholder()` that returns the html. Would it be better if
 this was a template?
 - Fix `setContent()`, it should empty the element before appending the new
 node.
 - `getHtml()` should always return a string.

 The default loadingPlaceholder has the dashicons-admin-media icon and a
 small "loading" CSS animation. Does it need to be more "distinct" or more
 styling? (To test it: edit line 50 in mce-view.js, from `var html =
 this.getHtml() || this.loadingPlaceholder();` to `var html =
 this.loadingPlaceholder();`.)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28761#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform