[wp-trac] [WordPress Trac] #26855: get_blogaddress_by_id used in wp-activate.php limits functionality in MU Domain Mapped Sites

[WordPress Trac]

#26855: get_blogaddress_by_id used in wp-activate.php limits functionality in MU
Domain Mapped Sites
-----------------------------------+------------------------------
 Reporter:  boboudreau             |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  Awaiting Review
Component:  Multisite              |     Version:  trunk
 Severity:  normal                 |  Resolution:
 Keywords:  2nd-opinion has-patch  |
-----------------------------------+------------------------------

Comment (by jeremyfelt):

 Thanks for the report and patch, @boboudreau!

 It would be worth taking a look at the handful of
 `get_blogaddress_by_id()` usages throughout core to figure out intent and
 to see if this change can be made safely.

 Where `get_site_url()` ultimately uses `get_option( 'siteurl' )` to
 retrieve the data from the `wp_#_options` table, `get_blogaddress_by_id()`
 gets everything via `get_blog_details()`, which pulls from the `wp_blogs`
 table.

 Separately, a concerted effort is coming together to try and make for more
 flexible domain usage in core. Depending on use case, this may impact the
 reasoning for using a domain mapping plugin to begin with and may impact
 this issue directly.

 In the meantime – you should be able to use the `blog_details` filter to
 modify `$details->domain` and `$details->path` when required for instances
 like this. I'm not entirely sure what other portions of core could be
 affected by filtering these values, but it should be fine for page loads
 such as `wp-activate.php` and `wp-signup.php`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26855#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform