[wp-trac] [WordPress Trac] #14541: Add boolean at remove_meta_box action

WordPress Trac noreply at wordpress.org
Tue Feb 25 16:56:31 UTC 2014


#14541: Add boolean at remove_meta_box action
----------------------------+----------------------
 Reporter:  Rahe            |       Owner:
     Type:  enhancement     |      Status:  closed
 Priority:  normal          |   Milestone:
Component:  Administration  |     Version:  3.0.1
 Severity:  normal          |  Resolution:  wontfix
 Keywords:  has-patch       |     Focuses:
----------------------------+----------------------
Changes (by markjaquith):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  3.9 =>


Comment:

 The patch as written won't work. It's doing an isset check, so will
 continue returning true every time it is called. Furthermore, the function
 needs to set the value to false even if it isn't already set, because for
 core meta boxes this acts as a forward-block on the meta box (i.e. calling
 add later won't work, because it has been marked as pre-removed).

 I also don't see the value of this return value. After calling it, it
 should be removed. Why do you care whether it was already marked as
 removed or not?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/14541#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list