[wp-trac] [WordPress Trac] #22392: save_state() in postbox.js should look at the hidden checkboxes instead of :hidden

[WordPress Trac]

#22392: save_state() in postbox.js should look at the hidden checkboxes instead of
:hidden
------------------------------------------------+--------------------------
 Reporter:  markoheijnen                        |       Owner:
     Type:  defect (bug)                        |      Status:  new
 Priority:  normal                              |   Milestone:  Awaiting
Component:  Editor                              |  Review
 Severity:  normal                              |     Version:
 Keywords:  dev-feedback has-patch 2nd-opinion  |  Resolution:
                                                |     Focuses:  javascript
------------------------------------------------+--------------------------
Changes (by adamsilverstein):

 * keywords:  dev-feedback has-patch => dev-feedback has-patch 2nd-opinion
 * focuses:   => javascript


Comment:

 This patch concept looks fine and in my brief testing I verified that it
 is returning the same list of ids.

 My only concern here would be that checkboxes may not always line up with
 the actual postboxes (although they should). Also, I'm not certain I
 understand the use case - you are hiding a metabox manually, but don't
 want it passed in the 'hidden' list?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22392#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform