[wp-trac] [WordPress Trac] #24409: Edit Image in TinyMCE editor revamp

[WordPress Trac]

#24409: Edit Image in TinyMCE editor revamp
----------------------------+-----------------------------
 Reporter:  eablokker       |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.9
Component:  Media           |     Version:  3.5.1
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  ui, javascript
----------------------------+-----------------------------
Changes (by azaozz):

 * focuses:   => ui, javascript


Comment:

 In 24409.05.patch:
 - Use a data attribute to "mark" the selected image. Keeping a reference
 to the node can crash in old IE.
 - Add/remove the data attribute when adding/removing the image toolbar.
 - Don't open the edit modal on second click on the image. Makes the "edit"
 button somewhat pointless and can sometimes trigger after resizing the
 image in IE.
 - When the image has caption: attempt to prevent IE11 from making the
 caption element resizable and wrapping it in thick border.
 - When the caret is inside a caption next to the image, pressing Enter
 will create a new <p> tag above the caption.

 Also added a transparent overlay on the selected image, only in Firefox
 and WebKit (interferes with resizing in old IE).

 TODO: UX review of the image toolbar and buttons, UI/styling review both
 inside the editor and the Edit Image modal.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24409#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform