[wp-trac] [WordPress Trac] #21632: Adding Imgur as an oEmbed provider

[WordPress Trac]

#21632: Adding Imgur as an oEmbed provider
-------------------------------------+--------------------------
 Reporter:  bradparbs                |       Owner:  markjaquith
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  3.9
Component:  Embeds                   |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+--------------------------
Changes (by nacin):

 * keywords:  has-patch good-first-bug needs-refresh => has-patch needs-
     refresh


Comment:

 Replying to [comment:18 Jayjdk]:
 > But I have a question - I'm unsure what is meant by:
 > > We need to confirm our regex is proper. If it is, it doesn't need to
 be a regex, as the non-regex variant now handles SSL and non-SSL.

 Sorry for the shorthand. oEmbed providers can be specified in two ways: as
 a regular expression and as a simple static string. In the latter case,
 `http://i.imgur.com/*` would be converted to `https?://i.imgur.com/.*`
 transparently. The HTTPS handling for non-regex providers is newer than my
 patch. I didn't look at my patch originally and figured that was the main
 reason for the regex.

 Clearly, it's not — imgur has multiple subdomains. At the very least, I've
 seen both 'i' and 'm' recently. So, the patch looks good.

 > (I have a patch but decided not to add it, as this ticket has been
 marked "good-first-bug").

 Appreciate it. In this case though, good-first-bugs != refresh a patch
 that otherwise works. I think John was hoping someone would investigate
 Imgur's endpoint, test it, and confirm we have the proper regex (are there
 other domains to check, for example?). But you and I pretty much handled
 that. :-)

 Time to commit this, I think.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21632#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform