[wp-trac] [WordPress Trac] #23307: shortcode_parse_atts may return empty string

WordPress Trac noreply at wordpress.org
Mon Feb 3 08:47:26 UTC 2014


#23307: shortcode_parse_atts may return empty string
----------------------------------------+------------------------------
 Reporter:  GaryJ                       |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Shortcodes                  |     Version:
 Severity:  minor                       |  Resolution:
 Keywords:  has-patch needs-unit-tests  |     Focuses:
----------------------------------------+------------------------------

Comment (by GaryJ):

 Replying to [comment:3 nacin]:
 > I'd also be curious when this was introduced — what's the history here?

 #5892

 > Patch doesn't look complete — if the pattern fails, it'd also return a
 string ( `ltrim( $text )` ). We should make it as consistent as possible.

 Looking at my comment above, I think this was indeed half a patch, as I
 wasn't sure what could / would be broken when potentially doing something
 with that left trim, so I just handled the simple case at the time.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23307#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list