[wp-trac] [WordPress Trac] #30556: Modern widgets default wrapper

WordPress Trac noreply at wordpress.org
Wed Dec 31 12:19:18 UTC 2014


#30556: Modern widgets default wrapper
-------------------------+-----------------------
 Reporter:  LeoPeo       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.2
Component:  Widgets      |     Version:  2.2
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  template
-------------------------+-----------------------

Comment (by valendesigns):

 Replying to [comment:15 LeoPeo]:
 > Thanks [comment:13 valendesigns]!
 > > I've added a simpler and more backwards compatible patch to address
 this tickets concerns and move it forward.
 > I like this solution, still I'm not convinced about the title class.
 >
 > For sure, this solution is more backward compatible, but the title class
 change needs to be well documented.
 > As theme developer, I don't expect this change declaring
 `add_theme_support('html5', 'widget');` and this can happen if I want to
 update the widget structure of my wordpress.com theme.

 This is already the established pattern and one we should be following
 here. If you look at how other html5 support has been added in the past
 you will see that the classes are renamed. For example, look at how
 `get_search_form` supports html5 and you will see that the classes are
 manipulated. It's to be expected.

 I don't believe, beyond saying what the defaults are, that any other
 documentation is needed to explain the class name change. That's because
 they don't yet exist and we're deciding what it should be in this ticket.
 It should not come as a shock to anyone that not only does the markup
 change, so does the class.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30556#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list