[wp-trac] [WordPress Trac] #30860: Add unit tests for plugin.php

WordPress Trac noreply at wordpress.org
Tue Dec 30 20:16:18 UTC 2014


#30860: Add unit tests for plugin.php
------------------------------+---------------------------
 Reporter:  sgrant            |       Owner:  boonebgorges
     Type:  enhancement       |      Status:  closed
 Priority:  normal            |   Milestone:  4.2
Component:  Build/Test Tools  |     Version:  trunk
 Severity:  normal            |  Resolution:  fixed
 Keywords:                    |     Focuses:
------------------------------+---------------------------

Comment (by boonebgorges):

 Replying to [comment:6 jorbin]:
 > We may still want to grep through the plugin and theme repos and make
 sure no one is using validate_active_plugins since this is a backwards
 incompatible change just to be on the safe side.

 I did before committing. Only a small handful of plugins use the value,
 and all of them do a `! empty()` check (mostly copypastaed from core),
 which is unaffected by the change. The only possible breakage would be
 someone doing a strict type check, like `is_null()`, but it's very
 difficult to imagine why this would ever be done in practice.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30860#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list