[wp-trac] [WordPress Trac] #30831: paginate_links() now needs add_args=false

[WordPress Trac]

#30831: paginate_links() now needs add_args=false
-----------------------------------+-----------------------
 Reporter:  bobbingwide            |       Owner:
     Type:  defect (bug)           |      Status:  new
 Priority:  normal                 |   Milestone:  4.1.1
Component:  Themes                 |     Version:  4.1
 Severity:  normal                 |  Resolution:
 Keywords:  has-patch 2nd-opinion  |     Focuses:  template
-----------------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:   => has-patch 2nd-opinion


Comment:

 [attachment:30831.test.patch] is a test that describes the problem.

 The problem dates to [29780] #29636. The root problem has something to do
 with the fact that `get_pagenum_link()` doesn't recognize the kinds of
 custom query arguments passed in the 'base' param of `paginate_links()`.
 I'm not sure how to fix this without doing a bunch of refactoring of
 `get_pagenum_link()` (and I'm not sure that this would be an appropriate
 fix anyway). Maybe we set the default `$query_args` to `false` if a custom
 'base' has been provided? [attachment:30831.patch] takes this route, and
 it passes all the tests, but I'd like the opinion of someone who is more
 familiar with the storied history of this set of functions.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30831#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform