[wp-trac] [WordPress Trac] #30760: Enable/disable full-height editor doesn't toggle without refreshing

WordPress Trac noreply at wordpress.org
Thu Dec 18 09:58:06 UTC 2014


#30760: Enable/disable full-height editor doesn't toggle without refreshing
--------------------------+-----------------------------
 Reporter:  Clorith       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Editor        |     Version:  4.0
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui, javascript
--------------------------+-----------------------------
Changes (by avryl):

 * keywords:   => needs-patch
 * focuses:  ui => ui, javascript
 * version:  trunk => 4.0
 * milestone:  Awaiting Review => Future Release


Comment:

 It looks like this only happens when there is no value in the user
 settings. In PHP there is a fallback to the default and the size can't be
 less than 50 or more than 5000 if the user setting is used. In JS the
 value is directly taken from the user settings: `var height =
 window.getUserSetting('ed_size');` on line 685 of editor-expand.js without
 any additional checks or fallback.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30760#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list