[wp-trac] [WordPress Trac] #21760: get_term_by() calls are not cached

[WordPress Trac]

#21760: get_term_by() calls are not cached
----------------------------+-----------------------------
 Reporter:  wonderboymusic  |       Owner:  wonderboymusic
     Type:  enhancement     |      Status:  reopened
 Priority:  normal          |   Milestone:  4.1
Component:  Taxonomy        |     Version:  2.3
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+-----------------------------

Comment (by ericmann):

 Replying to [comment:72 nacin]:
 > This most likely broke something on .com (whether they know about it yet
 or not) and in some plugins that mess directly with term caches. But it's
 not just that.

 Breaking anything at this stage feels like a sub-optimal situation. I
 agree with the overall sentiment that we should roll this back, take a
 step away, and revisit early in 4.2.

 > Here's how I would expect last_changed to be used: ...

 The notes in this workflow actually pan out to some great tests to make
 sure the code is fairly robust, doesn't break anything, and does exactly
 what we want it to do. Additionally, we can make sure that the changes to
 cache don't introduce any breaking changes that affect large installations
 like .com.

 > At this point, I think we need to revert this from the branch and try
 again in 4.2.

 Agree. Really wanted to see this ship in 4.1, but it doesn't feel ready.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21760#comment:74>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform