[wp-trac] [WordPress Trac] #30666: Add a comment to RTL and minified files for new contributors

WordPress Trac noreply at wordpress.org
Fri Dec 12 00:44:46 UTC 2014


#30666: Add a comment to RTL and minified files for new contributors
------------------------------+------------------------------
 Reporter:  SergeyBiryukov    |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  needs-patch       |     Focuses:  docs
------------------------------+------------------------------

Comment (by netweb):

 Replying to [comment:5 azaozz]:
 > That banner should be "static"/hard-coded. Including the date/time in
 there means the minified file will always change, even when there are no
 code changes. This triggers unneeded merges/updates downstream.
 The three Grunt tasks we'd look to do this with, `cssmin`, `cssjanus`, and
 `uglify` only compile files into the `/build` folder, they never touch
 files in `/src`.

 The WordPress packages (nightly, latest etc) are built using the Grunt
 tools but I don't believe the `/build` folder for any of these packages
 are version controlled, correct me here if I'm wrong. ;)

 We could also omit the date/time and just include the version and verbiage
 requests:
 {{{/*! This file was automatically generated as part of the WordPress
 4.1.0 release, please see https://make.wordpress.org/core/handbook/... for
 details on creating patches relating to this file. */}}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/30666#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list