[wp-trac] [WordPress Trac] #29367: Media Modal: the progress bar for each attachment no longer shows upload progress

[WordPress Trac]

#29367: Media Modal: the progress bar for each attachment no longer shows upload
progress
--------------------------+------------------------------
 Reporter:  gcorne        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Media         |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  javascript
--------------------------+------------------------------
Description changed by gcorne:

Old description:

> The progress bars in the attachment browser no longer animate when
> uploading. See https://cloudup.com/cAGpTEdfq6A for a demonstration. The
> progress bars worked correctly in 3.9.2.
>
> This broke in [29367] because {{{rerenderOnModelChange}}} is set to
> {{{true}}} so any change triggers the view to re-render. The upload
> progress isn't handled during a normal Attachment view render, so always
> re-rendering causes any change to the progress bar to be overwritten.

New description:

 The progress bars in the attachment browser no longer animate when
 uploading. See https://cloudup.com/cAGpTEdfq6A for a demonstration. The
 progress bars worked correctly in 3.9.2.

 This broke in [29266] because {{{rerenderOnModelChange}}} is set to
 {{{true}}} so any change triggers the view to re-render. The upload
 progress isn't handled during a normal Attachment view render, so always
 re-rendering causes any change to the progress bar to be overwritten.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29367#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform