[wp-trac] [WordPress Trac] #28975: Improve do_settings_fields() by including field ID on <tr> table row

WordPress Trac noreply at wordpress.org
Fri Aug 22 02:11:00 UTC 2014


#28975: Improve do_settings_fields() by including field ID on <tr> table row
-----------------------------+---------------------------------
 Reporter:  Jonnyauk         |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Administration   |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch close  |     Focuses:  ui, administration
-----------------------------+---------------------------------
Changes (by nacin):

 * keywords:  has-patch => has-patch close


Comment:

 As indicated in #28754, I'm not sure I'd want to do anything that ties us
 closer to the table markup we have here. The "hack" that is grabbing the
 field then traversing to find a common parent of itself and a label (or
 something) at least feels like a hack, that way we can feel less bad when
 it breaks.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28975#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list