[wp-trac] [WordPress Trac] #29230: When installing a plugin, plugin translations fail to install

[WordPress Trac]

#29230: When installing a plugin, plugin translations fail to install
-----------------------------+--------------------
 Reporter:  netweb           |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  4.0
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+--------------------
Changes (by ocean90):

 * keywords:   => has-patch
 * component:  I18N => Upgrade/Install
 * milestone:  Awaiting Review => 4.0


Comment:

 The `check_package()` callback from Plugin_Upgrader is still hooked into
 `upgrader_source_selection` and is used as first to check the translation
 package. After that the translation specific package check runs, which
 bails directly, because is_wp_error() is true.

 Pseudo stack:

 {{{
 add_filter('upgrader_source_selection', array( 'Plugin_Upgrader',
 'check_package') );
 WP_Upgrader->run( array() );
     do_action( 'upgrader_process_complete' );
        Language_Pack_Upgrader:async_upgrade()
           Language_Pack_Upgrader:upgrade()
               Language_Pack_Upgrader:bulk_upgrade()
               add_filter( 'upgrader_source_selection', array(
 'Language_Pack_Upgrader', 'check_package' ), 10, 2 );
               WP_Upgrader->run( array() );
               remove_filter( 'upgrader_source_selection', array(
 'Language_Pack_Upgrader', 'check_package' ) );
 remove_filter('upgrader_source_selection', array( 'Plugin_Upgrader',
 'check_package') );
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/29230#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform