[wp-trac] [WordPress Trac] #25788: Increase timeout for `plugins/update-check` API request

[WordPress Trac]

#25788: Increase timeout for `plugins/update-check` API request
------------------------------+--------------------------
 Reporter:  johnbillion       |       Owner:  johnbillion
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  4.0
Component:  Upgrade/Install   |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------------
Changes (by Denis-de-Bernardy):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Replying to [comment:12 SergeyBiryukov]:
 > #20002 would probably resolve this completely.

 Doubtful. The problem occurs at lines such as these:

 - https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/update.php?rev=28823#L117
 - https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/update.php?rev=28823#L292
 - https://core.trac.wordpress.org/browser/trunk/src/wp-
 includes/update.php?rev=28823#L447

 Why we're triggering an `E_USER_*` error on this is beyond me, btw. This
 fires up the Symfony debugger, and leaves you staring at a screen full
 with the details of the exception.

 Methinks the correct fix would be to get rid of that, and trigger the
 error only when the cron is running for the sake of logging it. On the
 front end, it should instead display an appropriately colored (warning)
 message in the admin UI and trigger no PHP error at all.

 Moreover, and as stated in a separate ticket, I can't hep but point out
 why anyone privileged with an SSL-enabled HTTP transport gets to see this
 kind of warning but not those who don't.

 Lastly, I'd like to highlight that the timeout is either ignored or not
 honored, or the wordpress.org API times out earlier than whatever is
 specified. Because, well, I increased it to a ridiculously high value (30
 seconds) for 10 plugins, and it's still timing out -- long before thirty
 seconds elapse.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25788#comment:13>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform