[wp-trac] [WordPress Trac] #27365: Upgrader bulk_upgrade() functions do not return the correct data

[WordPress Trac]

#27365: Upgrader bulk_upgrade() functions do not return the correct data
---------------------------------+-----------------------------
 Reporter:  chrisjean            |       Owner:
     Type:  defect (bug)         |      Status:  new
 Priority:  normal               |   Milestone:  Future Release
Component:  Upgrade/Install      |     Version:  2.9
 Severity:  normal               |  Resolution:
 Keywords:  has-patch 4.0-early  |     Focuses:
---------------------------------+-----------------------------

Comment (by jdgrimes):

 Somehow this never got on the 4.0 milestone.

 ----

 This is also an issue in the `install()` and `upgrade()` methods of the
 plugin and theme upgraders. `WP_Upgrader::run()` is called, but the return
 value isn't used, just `$this->result`. Which again means that valuable
 error info is getting lost on the calling function. Of course, these
 upgraders were designed to output the error messages to the user directly
 through the skins, but since they are returning information, they might as
 well return useful information.

 Really, the upgraders could use some unit tests (difficult, but not
 impossible), to at least define the expected behavior.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27365#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform