[wp-trac] [WordPress Trac] #25280: wp_localize_script unexpectedly converts numbers to strings

[WordPress Trac]

#25280: wp_localize_script unexpectedly converts numbers to strings
-----------------------------+------------------
 Reporter:  adamsilverstein  |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  4.0
Component:  I18N             |     Version:  3.2
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |     Focuses:
-----------------------------+------------------

Comment (by adamsilverstein):

 Replying to [comment:14 c3mdigital]:
 > As per discussion with @nacin,
 [https://core.trac.wordpress.org/attachment/ticket/25280/2580.3.patch
 2580.3.patch] changes "if" check to only pass strings to
 `html_entity_decode()` and removes cast to string.

 This seems like a great solution. The sooner we get this in, the longer we
 have to test it :) My only concern is that we may break plugins that are
 **expecting** their numbers to be converted to strings. Not sure we can
 search for such breakage, and may have to be satisfied with making sure
 the change is clearly documented. Commit!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25280#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform