[wp-trac] [WordPress Trac] #27780: Widget Customizer: Before and after widget check!

[WordPress Trac]

#27780: Widget Customizer: Before and after widget check!
--------------------------+--------------------
 Reporter:  jetonr        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.9
Component:  Appearance    |     Version:  trunk
 Severity:  minor         |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------

Comment (by westonruter):

 Replying to [comment:6 ocean90]:
 > [attachment:27780.patch] just ignores such widgets for the highlighting.
 Another idea is to add a dummy wrapper around the widget, but that could
 break themes.

 Yes, this is a good approach. I had thought the problem was with the first
 `replace` not the second one, so I was considering something like:


 {{{
 ( sidebar.before_widget || '' ).replace( '%1$s', '' ).replace( '%2$s', ''
 )
 }}}

 But it seems clear that the issue isn't that `sidebar.before_widget` is
 not defined, but rather that the `class` attribute is undefined/missing on
 the `emptyWidget` widget template (since there is no container element).
 So, good on you ocean90.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27780#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform