[wp-trac] [WordPress Trac] #27758: WP_Error data is false in _unzip_file_ziparchive

[WordPress Trac]

#27758: WP_Error data is false in _unzip_file_ziparchive
-----------------------------+------------------------------
 Reporter:  ruud@…           |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:  3.7
 Severity:  normal           |  Resolution:
 Keywords:                   |     Focuses:
-----------------------------+------------------------------
Changes (by SergeyBiryukov):

 * version:  3.8.1 => 3.7


Old description:

> This is a follow-up to #22704, and the short version because after my
> long version crashed on 'continue to preview' :(
>
> return new WP_Error( 'mkdir_failed_ziparchive', __( 'Could not create
> directory.' ), substr( $_dir, strlen( $to ) ) );
>
> substr( $_dir, strlen( $to ) ) results in false for the 'upgrade' folder
> and the zipfile folder itself. For the other folders the 'data' is simply
> not very informative and could be even confusing.
>
> Before #25693, it used to be just '$_dir'; isn't that a much more
> informative feedback?

New description:

 This is a follow-up to #22704, and the short version because after my long
 version crashed on 'continue to preview' :(
 {{{
 return new WP_Error( 'mkdir_failed_ziparchive', __( 'Could not create
 directory.' ), substr( $_dir, strlen( $to ) ) );
 }}}
 `substr( $_dir, strlen( $to ) )` results in false for the 'upgrade' folder
 and the zipfile folder itself. For the other folders the 'data' is simply
 not very informative and could be even confusing.

 Before [25780], it used to be just `$_dir`; isn't that a much more
 informative feedback?

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27758#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform