[wp-trac] [WordPress Trac] #27746: Trunk Regression: XML-RPC could fail with erroneous disabled status

[WordPress Trac]

#27746: Trunk Regression: XML-RPC could fail with erroneous disabled status
------------------------------+--------------------
 Reporter:  redsweater        |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.9
Component:  XML-RPC           |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------

Comment (by SergeyBiryukov):

 > The changes starting at line 194 add multiple lines to what was
 previously a 1 line statement following an unbracketed if statement. The
 result is the line following the comment is now executed unconditionally:
 > `$enabled = apply_filters( 'option_enable_xmlrpc', true );`

 From my reading, that's not the case. It's still a single-line statement,
 the comment block doesn't affect the logic.

 As [https://irclogs.wordpress.org/chanlog.php?channel=wordpress-
 dev&day=2014-04-10&sort=asc#m829700 noted in IRC], the issue appears to be
 caused by Wordfence Security plugin update.

 Looks like [attachment:27506.5.diff:ticket:27506] on #27506 is the way to
 go here.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27746#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform