[wp-trac] [WordPress Trac] #21785: Add header image uploads with cropping to the customizer

[WordPress Trac]

#21785: Add header image uploads with cropping to the customizer
----------------------------+-----------------------------------------
 Reporter:  nacin           |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.9
Component:  Appearance      |     Version:  3.4
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  javascript, administration
----------------------------+-----------------------------------------

Comment (by davidakennedy):

 Replying to [comment:59 mcsf]:
 > attachment:a11y-ui-improvements.diff includes ehgy's accessibility
 changes (see above), as well as UI improvements as
 [https://irclogs.wordpress.org/chanlog.php?channel=wordpress-
 dev&day=2014-03-28&sort=asc#m820791 discussed in IRC], namely:
 > - Prefer a lighter UI.
 > - Make the UI more coherent with the rest of the Customizer (button
 style, borders).
 > - Don't hide the selected header, but rather highlight it. Adjust logic
 accordingly.
 > - Stop the Customizer controls from jumping around when selecting a
 header.
 > Plus:
 > - Fix ordering of headers by defaulting timestamps to 0.
 > - Force height for Randomize buttons instead of inferring it from other
 Header views.
 > - Some removal of code.

 See #27598.

 Regarding first issue: The current buttons in the new header image area of
 the theme customizer are not actual buttons... This works perfectly now
 and provides much more context to assistive technologies.

 Second issue: This type of pattern is even more problematic in the
 "Randomize uploaded headers" button... This works perfectly now and
 provides much more context to assistive technologies. However, it looks
 like there's something off visually for me. This may be an on my end...
 See the button-like style happening behind each randomized button:
 https://www.dropbox.com/lightbox/home/Public/WPTicket-27598

 Third issue: Also the markup for an uploaded header image that can be
 clicked to be set needs more context as well... This also works perfectly
 now and provides much more context to assistive technologies.

 Fourth issue: If a user explicitly sets alternative text in the Media
 Library, that attribute doesn't seem to be displayed in the Theme
 Customizer Header Image area... The Header Image for Current image does
 not seem to be getting an alternative text attribute. The other two
 (Previously uploaded and Suggested) do, and that's great! The Current
 image header does need one in order for screen reader users to know which
 image is there. This would be a must have.

 Great work ehg, mcsf and others! This also sets us up well for future
 enhancements here, especially around WAI-ARIA.

 Let me know if there are any questions!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21785#comment:64>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform