[wp-trac] [WordPress Trac] #27538: Widget Customizer: Persistent object cache/Transients causes certain previewed widgets to leak outside of customizer

WordPress Trac noreply at wordpress.org
Thu Apr 3 02:45:39 UTC 2014


#27538: Widget Customizer: Persistent object cache/Transients causes certain
previewed widgets to leak outside of customizer
--------------------------+--------------------
 Reporter:  westonruter   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  3.9
Component:  Widgets       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+--------------------

Comment (by David_Rothstein):

 In {{{27538.4.patch}}}, the removal of the {{{global $comments,
 $comment}}} line is problematic (among other things, it causes all comment
 authors in the Recent Comments widget to be printed as "Anonymous").

 Also, what's the rationale for this approach over something like
 {{{27538.3.patch}}}?  {{{27538.3.patch}}} is simpler code for widgets to
 deal with, and by addressing the issue with the bad cache key directly, it
 also prevents other cache leaking bugs from occurring in the future (see
 for example the code snippet I pasted earlier in this ticket).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27538#comment:14>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list