[wp-trac] [WordPress Trac] #25430: Hooks Docs: wp-admin/options-reading.php

[WordPress Trac]

#25430: Hooks Docs: wp-admin/options-reading.php
--------------------------+------------------------------
 Reporter:  siobhyb       |       Owner:  DrewAPicture
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Inline Docs   |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+------------------------------
Changes (by DrewAPicture):

 * keywords:  has-patch => needs-patch
 * owner:   => DrewAPicture
 * status:  new => reviewing
 * type:  enhancement => defect (bug)


Comment:

 Hi Siobhan, thanks for the patch :)

 So, this hook is kind of interesting because it mostly serves to provide
 backward-compatibility for adding additional-level privacy setting to the
 fieldset that used to live in the now-defunct options-privacy.php See
 #16416 for when those settings screens were consolidated.

 And if you look at the current code, you'll notice that the section of the
 table that the action runs in is only displayed if that hook has a
 callback hooked to it.

 The logic behind it is explained pretty well in the commit message for
 [21838]:

   When blog_public only has two values (as judged by whether the
 blog_privacy_selector action is used), convert from radio buttons to a
 checkbox, and rename from 'Site Visibility' to a more specific 'Search
 Engine Visibility'.

 The reason I bring this up is that we should find a way to succinctly
 explain this behavior in the hook doc, probably using a long (but not too
 long!) description.

 Also, in the future, could you please remember to generate patches from
 the WordPress root? :)

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25430#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software