[wp-trac] [WordPress Trac] #25425: Last separator in network and user menus not removed

[WordPress Trac]

#25425: Last separator in network and user menus not removed
-----------------------------+------------------------------
 Reporter:  johnjamesjacoby  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Network Admin    |     Version:  3.0
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+------------------------------
Description changed by johnjamesjacoby:

Old description:

> In `/wp-admin/network/` and `/wp-admin/user/` the last separator is not
> trimmed off.
>
> This is caused by the ID of those separators being `wp-menu-separator-
> last` and not `wp-menu-separator`
>
> Screen shots attached to outline the problem.
>
> * First patch renames the final separators, since `wp-menu-separator-
> last` is not referenced anywhere else in WordPress core.
> * Second patch keeps the ID's the same (for backpat with who-knows-what)
> and tweaks the code that removes the final separator in `/wp-
> admin/includes/menu.php` instead.
> * Bonus patch to adjust a separator capability from `read` to `exist` to
> match the other two.
>
> Related'ish: #23182, #24104.

New description:

 In `/wp-admin/network/` and `/wp-admin/user/` the last separator is not
 trimmed off.

 This is caused by the ID of those separators being `wp-menu-separator-
 last` and not `wp-menu-separator`

 Screen shots attached to outline the problem.

 * First patch renames the final separators, since `wp-menu-separator-last`
 is not referenced anywhere else in WordPress core.
 * Second patch keeps the ID's the same (for backpat with who-knows-what)
 and tweaks the code that removes the final separator in `/wp-
 admin/includes/menu.php` instead.
 * Bonus patch to adjust a separator capability from `read` to `exist` to
 match the other two.
 * Final patch combines all three patches together.

 Related'ish: #23182, #24104.

--

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25425#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software