[wp-trac] [WordPress Trac] #13874: Add package argument to "_deprecated_function" function

WordPress Trac noreply at wordpress.org
Tue Sep 24 01:37:58 UTC 2013

#13874: Add package argument to "_deprecated_function" function
 Reporter:  johnjamesjacoby   |       Owner:  westi
     Type:  enhancement       |      Status:  accepted
 Priority:  normal            |   Milestone:  3.7
Component:  Warnings/Notices  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |

Comment (by nacin):

 Replying to [comment:17 ericlewis]:
 > Modifying _deprecated_function and _deprecated_file to allow for more
 integration with third-party code is great. However, these functions
 remain prefixed with underscores to denote them as private, as well as in
 the Docblock above. Deprecating these deprecated functions in lieu of un-
 prefixed ones may be overkill and quite the meta commit, but we should at
 least change the Dockblock.

 I don't feel strongly either way, but if we're going to add package
 support to this, new functions (with the package argument being first)
 might not be a bad idea.

 > I'm coming across more and more situations where a function's name is
 misleading, and there's a suggestion to rename it; a top-down decision on
 what to do in these situations would be good.

 Usually we err on not renaming functions for the sake of renaming them. We
 would rather do things like overhaul their internals or arguments in the
 process, otherwise we're just using up the existing namespace (and
 annoying developers by deprecating potentially commonly used functions
 just for a rename).

Ticket URL: <http://core.trac.wordpress.org/ticket/13874#comment:22>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list