[wp-trac] [WordPress Trac] #18201: Verify updates with md5 checks

[WordPress Trac]

#18201: Verify updates with md5 checks
-------------------------------------+------------------
 Reporter:  nacin                    |       Owner:
     Type:  feature request          |      Status:  new
 Priority:  low                      |   Milestone:  3.7
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Comment (by dd32):

 > Attachment attachment:18201.7.diff​ added

 That's attachment:18201.6.diff​ merged to 3.6 and a bunch of syntax
 errors, and code fixes..
 * _copy_dir()  uses a regular expression internally for the skip list,
 apparently a 40,000-character long string isn't advisable as a regular
 expression..  The replacement strpos() one I tried (included in patch)
 also didn't work as it'd find 'wp-includes' within '/wp-
 includes/some/file'  and fail.. The whole skip list functionality is
 really broken and doesn't work for anything more than a simple unique-
 named folder (ie. wp-content).
 * The about.php redirect keeps kicking in, although, as far as I could
 tell, I neutered it.. get ready to hit escape after the update process
 finishes
 * The get_core_checksums() function won't exist when upgrading from
 pre-3.7, so it needs checking it exists before it's called in `wp-
 admin/includes/update-core.php`
 * See all the TODO and TESTING comments throughout
 * includes PHP5.4-only debug included (short-form array notation), as a
 FYI.
 * Uses $from / $to (which is a remote FTP path) as a local path often,
 many cases updated to ABSPATH, but, some things such as the $working_dir
 cannot be easily mapped from FTP path to Local path
 * Added a few more upgrade messages (maintainence mode / verifying files)
 so it's easier to see what's happening

 That's all I've got right now..
 If you want to test this patch on an install, some helpful commands:
 {{{
 while( true ) {
    svn revert -R . && cat 18201.diff | patch -p0
    #make changes
    svn diff > 18201.diff
    #hit update
 }
 }}}

--
Ticket URL: <http://core.trac.wordpress.org/ticket/18201#comment:23>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software