[wp-trac] [WordPress Trac] #25208: Missing ntlm_sasl_client.php - it's a mistery

WordPress Trac noreply at wordpress.org
Sun Sep 15 00:29:10 UTC 2013

#25208: Missing ntlm_sasl_client.php - it's a mistery
 Reporter:  Claudiu Ceia        |       Owner:
     Type:  defect (bug)        |      Status:  closed
 Priority:  normal              |   Milestone:
Component:  External Libraries  |     Version:  3.6
 Severity:  minor               |  Resolution:  wontfix
 Keywords:                      |

Comment (by bpetty):

 Well, one of the big issues with adding it now is that we've never had it
 in there before, so we also never had to deal with the issue of supporting
 something that was was supported in the past - but shouldn't be because
 no-one should be using it at this point. If we add it now, we lose that.
 Fact is, it never worked before, so there's really no concern with never
 adding it in there now.

 What would be a better solution to your HHVM problem would be to submit a
 patch to PHPMailer upstream that knows to conditionally check for that
 file since it is actually supposed to be an optional "extra" feature
 anyway. In fact, this really needs to happen before we consider adding our
 own custom stubbed file for it in WordPress (just like we advise users not
 to modify core files, we try not to modify included 3rd party files either
 ourselves - and this would count as one). We don't include any of the
 "extra" files that come with PHPMailer right now actually, and have never
 really needed to for many of the same reasons.

 Doesn't HHVM have some other way to get around issues like this as well?
 I'd think it would be very common with all sorts of PHP applications with
 dynamically included PHP files.

Ticket URL: <http://core.trac.wordpress.org/ticket/25208#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list