[wp-trac] [WordPress Trac] #25317: Wrong guess in wp_guess_url() for symlinked install, or unit tests

WordPress Trac noreply at wordpress.org
Sat Sep 14 00:26:58 UTC 2013


#25317: Wrong guess in wp_guess_url() for symlinked install, or unit tests
-----------------------------+--------------------
 Reporter:  bpetty           |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  highest omg bbq  |   Milestone:  3.7
Component:  Upgrade/Install  |     Version:  trunk
 Severity:  blocker          |  Resolution:
 Keywords:  has-patch        |
-----------------------------+--------------------

Comment (by dd32):

 > attachment:25317.patch​

 That last fallback case might as well be `$path =
 $_SERVER['REQUEST_URI']`, since wp-admin and wp-login are caught in the
 first block.

 I would love it if we could simply fix ABSPATH once-and-for-all,
 sanitizing the slashes at define time..

 What we need to get is a set of unit tests here, except, the fact we're
 dealing with constants kind of makes that almost impossible with the
 current testing methodology. thoughts?

 Perhaps those with scenario's that break can post a set of $_SERVER data
 that could be used in a test? (SCRIPT_FILENAME, PHP_SELF, REQUEST_URI,
 ABSPATH, etc.)

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25317#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list