[wp-trac] [WordPress Trac] #18614: post_type_archive_title doesn't work when tax_query is added to wp_query

[WordPress Trac]

#18614: post_type_archive_title doesn't work when tax_query is added to wp_query
----------------------------------------+-----------------------------
 Reporter:  wonderboymusic              |       Owner:  wonderboymusic
     Type:  defect (bug)                |      Status:  closed
 Priority:  normal                      |   Milestone:  3.7
Component:  Template                    |     Version:  3.2
 Severity:  normal                      |  Resolution:  fixed
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+-----------------------------

Comment (by nacin):

 1. `get_post_type_object( get_query_var( 'post_type' ) );` — could that
 fail if the post_type QV is an array? That's the only thing that jumps
 out.

 2. Could we get away with demoting the is_post_type_archive() and is_tax()
 conditionals in template-loader.php to below is_front_page() and
 is_home()? Then is_home() will happen right before is_post_type_archive(),
 possibly setting the stage for that to be cleaned up in the future, as it
 is essentially the 'post' post type archive (plus some other special
 sauce). It would also make a lot more sense as is_tax() was kind of
 nonchalantly stuffed up at the top originally. Does anyone see any side
 effects?

--
Ticket URL: <http://core.trac.wordpress.org/ticket/18614#comment:32>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software