[wp-trac] [WordPress Trac] #25219: DISALLOW_FILE_MODS shouldn't remove update notifications

WordPress Trac noreply at wordpress.org
Wed Sep 4 12:12:32 UTC 2013


#25219: DISALLOW_FILE_MODS shouldn't remove update notifications
-----------------------------+------------------------------
 Reporter:  iandunn          |       Owner:
     Type:  enhancement      |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+------------------------------

Comment (by dd32):

 I don't think adding a new meta_cap is really needed honestly.

 I'd just remove the cap check in `wp_plugin_update_rows()` myself, the
 `wp_plugin_update_row()` function includes a cap check which either
 notifies about the update, or notifies and links to a update depending on
 the users auth.
 This check in particular was added to replace a `if ( is_multisite() &&
 !is_super_admin() )` check in [12753], it seems that the previous check
 was more appropriate IMHO.

 The Core update nag check also tests `if ( is_multisite() &&
 !current_user_can('update_core') )` which I also feel should switch to
 nagging super admins..

 The Dashboard -> Updates page is a bit newer though, and allowing access
 to that would be a little more interesting.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25219#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list