[wp-trac] [WordPress Trac] #25094: Twenty Fourteen: Audit Theme Customization Options

WordPress Trac noreply at wordpress.org
Sun Sep 1 08:32:30 UTC 2013

#25094: Twenty Fourteen: Audit Theme Customization Options
 Reporter:  celloexpressions  |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  3.8
Component:  Bundled Theme     |     Version:  trunk
 Severity:  normal            |  Resolution:
 Keywords:  has-patch         |

Comment (by celloexpressions):

 [attachment:25094.accent-color.2.diff] implements obenland's suggestions
 and also only outputs the color overrides if a custom color is selected
 (borrowed from Twenty Eleven); this way, child themes and custom css
 aren't overridden. We can also keep the current shades for all three
 default colors, since they aren't generating.

 I think Accent Color is better because we're changing more than just the
 links. This control lets you change ''all'' of the colors in Twenty
 Fourteen other than the background and grayscale tones. While that isn't
 much beyond the links (notably, it covers the header search button and the
 text selection color), I think the visual impact warrants a more
 substantial label.

 In terms of the internal variable names, both generated colors are
 actually lighter than the original, so I'm not sure what the best naming
 convention would be.

 I would like to apply the primary accent (or whatever we call it) color to
 the editor stylesheet for links and ::selection but the only method I know
 of to do that requires creating a file; anyone know a better way to load a
 few lines of css into TinyMCE?

 Revisiting the color generation itself, anyone else think we should
 lighten the first generated color a bit more than 14 steps? The best place
 to test the contrast between those shades is the normal and hover states
 of the search button; I've found the contrast to be small enough to look
 unintentional for several initial colors.

Ticket URL: <http://core.trac.wordpress.org/ticket/25094#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software

More information about the wp-trac mailing list