[wp-trac] [WordPress Trac] #25776: $is_nginx global not defined in vars.php

[WordPress Trac]

#25776: $is_nginx global not defined in vars.php
-----------------------------+------------------------------
 Reporter:  johnjamesjacoby  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  General          |     Version:  3.7
 Severity:  minor            |  Resolution:
 Keywords:  has-patch        |
-----------------------------+------------------------------

Comment (by johnjamesjacoby):

 Because `vars.php` is included in the global scope and the only place that
 references the `$is_nginx` global directly (`options-permalink.php`) is
 also included in the global scope, this does not cause any problems.
 `got_url_rewrite` uses `$GLOBALS['is_nginx']` rather than define the
 global, which is how it gets around it also.

 Arguably, we could delete the definitions completely at the top of the
 file, since `vars.php` is only included directly via `wp-settings.php` in
 the global scope, meaning all variables in `vars.php` are considered
 global anyways.

 Striving for consistency, would be nice to see it added. Additionally, the
 doc-block at the top of `vars.php` should be updated to include the nginx
 check.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25776#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software