[wp-trac] [WordPress Trac] #25554: Twenty Fourteen: Revise the primary navigation style pattern.

[WordPress Trac]

#25554: Twenty Fourteen: Revise the primary navigation style pattern.
-------------------------------------+---------------------------
 Reporter:  iamtakashi               |       Owner:  lancewillett
     Type:  enhancement              |      Status:  reopened
 Priority:  normal                   |   Milestone:  3.8
Component:  Bundled Theme            |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+---------------------------

Comment (by iamtakashi):

 Discussed today in [https://irclogs.wordpress.org/chanlog.php?channel
 =wordpress-themes&day=2013-10-29&sort=asc#m73599 Twenty Fourteen office
 hours].

 '''The issue:'''
 When a site has a really long menu which makes the header taller, it masks
 a part of the site: https://cloudup.com/crxv2tGH5lr . This only happens
 when custom header image is not added because the fixed header is done by
 only CSS in the case: (`.masthead-fixed .site-main` has top margin of
 48px which is the height of the header when menu is not too long), but
 obviously if the header gets taller, it masks that extra pixels.

 Several options are suggested in the chat.

 * Get the height of the fixed header and adjust the top margin, via JS.
 * No fixed header when the menu is long and the header becomes more than
 48px tall.
 * If the menu is too long to fit in the 48px header, we turn it into the
 mobile menu. So that the header is always 48px tall.
 * Dropping the fixed header all together like Twenty Thirteen but this
 should be a last resort in my opinion.

 Let's discuss here to choose the best option.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25554#comment:16>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software