[wp-trac] [WordPress Trac] #25497: Hooks Docs: wp-admin/network/site-users.php

[WordPress Trac]

#25497: Hooks Docs: wp-admin/network/site-users.php
--------------------------+------------------------------
 Reporter:  sboisvert     |       Owner:  kpdesign
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Inline Docs   |     Version:  trunk
 Severity:  trivial       |  Resolution:
 Keywords:  needs-patch   |
--------------------------+------------------------------
Changes (by DrewAPicture):

 * keywords:  has-patch => needs-patch
 * owner:   => kpdesign
 * status:  new => reviewing


Comment:

 Hi, thanks for the patch. Some notes on [attachment:site-users.php.patch]:
 * All short descriptions need a period.

 `show_network_site_users_add_existing_form` filter:
 * The suggested language for a boolean-style filter is to say something
 like, "Whether to <perform something>". It's also necessary to provide the
 context, in this case that would be Multisite. So maybe change "Disable
 showing add existing user form" to something like "Whether to show the Add
 Existing User form in the Site Users screen."

 `network_site_users_after_list_table` hook:
 * Remove the blank line after the `@since` line.
 * The boolean parameter with a value of `true` is missing from the
 `do_action()` call
 * Add a parameter doc for the missing boolean parameter

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25497#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software