[wp-trac] [WordPress Trac] #22704: Automatic Core Updates

[WordPress Trac]

#22704: Automatic Core Updates
-----------------------------+-----------------------
 Reporter:  pento            |       Owner:  pento
     Type:  task (blessed)   |      Status:  assigned
 Priority:  normal           |   Milestone:  3.7
Component:  Upgrade/Install  |     Version:  3.5
 Severity:  normal           |  Resolution:
 Keywords:  has-patch        |
-----------------------------+-----------------------

Comment (by Denis-de-Bernardy):

 Replying to [comment:95 nacin]:
 > In [changeset:"25700"]:
 > {{{
 > #!CommitTicketReference repository="" revision="25700"
 > Be as sure as possible that WordPress is not under version control when
 deciding if we should do automatic updates.
 >
 > see #22704.
 > }}}

 This fails to detect WP when it's installed using e.g. Mark Jacquith's WP-
 Skeleton:

 /index.php
 /wp <-- abs path is here

 At the very least, we should manage that setup, since rolling out a site
 with WP in the main folder hardly is best practice for customer sites.

 In my own site's template, detecting the above would still fail since I've
 the same as above even further up, in /www alongside a /bin folder. I
 presume that is common enough as well to at least consider detecting it.

 More generally and ideally, you'd scan for .git as low in the folder
 hierarchy as file permissions allow you to to make the same check work
 with more exotic use-cases.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/22704#comment:96>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software