[wp-trac] [WordPress Trac] #26200: Twenty Fourteen: Drop Down Menu icons

[WordPress Trac]

#26200: Twenty Fourteen: Drop Down Menu icons
---------------------------+------------------------------
 Reporter:  binarymoon     |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------------------
Changes (by iamtakashi):

 * keywords:   => has-patch
 * version:   => trunk


Comment:

 @binarymoon

 I worked on this a bit further and made a patch
 [http://core.trac.wordpress.org/attachment/ticket/26200/26200.5.diff
 26200.5.diff] based on yours. Here are notes for you and I hope you find
 these useful.

 * The arrows need be added separately to the primary and the secondary
 navigation with different break points because the secondary navigation
 remains the mobile style until wider browser width. With your patch,
 arrows for the secondary navigation had appeared weird places when browser
 width is between from 782px to 810px.
 * The arrows should also be added to the fallback page menu so that users
 who don't set a custom menu also see the arrows.
 * Making the width of `.primary-navigation ul ul a` flexible with `min-
 width` does prevent the gap but I'd like to keep the width of the children
 the same regardless having grand children or not.
 * I believe there is no need to specify sizes of the arrow with `width: 0`
 and `height: 0`, and restating it as block element.
 * I made the arrow a little bit smaller and tweaked its position.
 * Let's use double quotes per [http://make.wordpress.org/core/handbook
 /coding-standards/css/ CSS coding standards].
 * I personally like ordering properties alphabetically with certain
 exceptions.

 This is an awesome suggestion, thank you!

--
Ticket URL: <http://core.trac.wordpress.org/ticket/26200#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software