[wp-trac] [WordPress Trac] #25721: Consolidate a couple of filters to the WP_Image_Editor base class

[WordPress Trac]

#25721: Consolidate a couple of filters to the WP_Image_Editor base class
------------------------------------+------------------------
 Reporter:  markoheijnen            |       Owner:
     Type:  enhancement             |      Status:  reviewing
 Priority:  normal                  |   Milestone:  3.8
Component:  Media                   |     Version:  3.5
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------

Comment (by DH-Shredder):

 Replying to [comment:20 markoheijnen]:
 > I would recommend to just make the argument for set_quality() required.
 >
 > I also would remove the weird check in set_quality for JPEG. To set the
 quality from 0 to 1 to protect backwards compatibility doesn't make a lot
 sense. No one will do so since images will get really crappy.

 Both of these were backcompat decisions -- in particular the second,
 though.

 Because we're now enforcing proper values, if someone passes to
 jpeg_quality a 0 quality, it will WP_Error.  I agree that it's not
 particularly pretty, but don't see why we should break image manipulation
 entirely for anyone who was doing that previously.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25721#comment:21>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software