[wp-trac] [WordPress Trac] #25721: Consolidate a couple of filters to the WP_Image_Editor base class

[WordPress Trac]

#25721: Consolidate a couple of filters to the WP_Image_Editor base class
------------------------------------+------------------------
 Reporter:  markoheijnen            |       Owner:
     Type:  enhancement             |      Status:  reviewing
 Priority:  normal                  |   Milestone:  3.8
Component:  Media                   |     Version:  3.5
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+------------------------

Comment (by DH-Shredder):

 Attached [attachment:25721.4.diff​].

 This includes previous patches, and also does the following:
 - Enforce proper quality ranges
 - Standardize set_quality() method signatures between base and Imagick.
 - Return WP_Error where appropriate.
 - Update Inline docs for correctness

 One point of contention here is the behaviour when running set_quality()
 by itself.

 Previously, in Imagick (but not base), if you called it without an
 argument, it would set $this->quality as the quality, and return as to
 whether that succeeded.  Because it was in there previously, for
 backcompat, I've standardized on that behavior.

 However, since Imagick is no longer relying on the behavior, the other
 option would be to make the argument required.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25721#comment:19>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software