[wp-trac] [WordPress Trac] #6297: Unbalanced tags across more and nextpage tags

WordPress Trac noreply at wordpress.org
Tue Nov 26 19:48:12 UTC 2013


#6297: Unbalanced tags across more and nextpage tags
--------------------------+-----------------------
 Reporter:  tellyworth    |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  3.8
Component:  Formatting    |     Version:  2.5
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by mdawaffe):

 On further inspection, the behavior here is a little odd.

 For nextpage, it makes sense to fix the markup on save to ensure the
 markup of each page is sane.

 For more, it doesn't.  For example, for the following:

 {{{
 <blockquote>
 Above
 <!--more-->
 Below
 </blockquote>
 }}}

 On an index page, I would expect to see either:

 {{{
 <blockquote>
 Above
 <a href="#more-123">...</a>
 </blockquote>
 }}}

 or maybe:

 {{{
 <blockquote>
 Above
 </blockquote>
 <a href="#more-123">...</a>
 }}}

 In 3.7.1, I see the former.  In [26050], I see the latter.  I'm not sure
 which is "better", but the difference is not backward compatible.

 More importantly, on a permalink page, I would expect to see:

 {{{
 <blockquote>
 Above
 <a id="more-123></a>
 Below
 </blockquote>
 }}}

 That's what I see in 3.7.1.  In [26050], though, I see:

 {{{
 <blockquote>
 Above
 </blockquote>
 <a id="more-123></a>
 Below
 }}}

 Which is unexpected.

 For nextpage, each piece of text is only ever visible on one page, so
 fixing each page's markup individually makes sense.

 For more, some pieces of text are shown in two different contexts, so
 fixing the markup "before the jump" independently from the markup "after
 the jump" doesn't quite work.

 Idea: Balance tags on save only by page.  Balance tags of index page's
 pre-more-markup on display.
 Cons:
 * More work on display.
 * Using a filter on display that plugins may expect to only be used on
 save?
 * Toggling the setting changes the display of already written posts.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/6297#comment:25>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list