[wp-trac] [WordPress Trac] #25524: Twenty Thirteen – single attachment page image height

[WordPress Trac]

#25524: Twenty Thirteen – single attachment page image height
--------------------------------+------------------
 Reporter:  Marco_Teethgrinder  |       Owner:
     Type:  defect (bug)        |      Status:  new
 Priority:  low                 |   Milestone:  3.8
Component:  Bundled Theme       |     Version:  3.6
 Severity:  normal              |  Resolution:
 Keywords:  has-patch           |
--------------------------------+------------------

Comment (by chipbennett):

 Replying to [comment:3 lancewillett]:
 > Turns out it's exactly the opposite. We explicitly decided not to use a
 big number like 9999 because of portrait images. If you have a really big
 portrait image it takes up way too much room on the page, and also is
 jarring when viewing a set of images in a row.

 Is `twentythirteen_the_attached_image()` only output in `image.php`? If
 so, you should never have a case of "viewing a set of images in a row",
 since `image.php` is a single-post view for an attachment image.
 >
 > Setting the height to 724 means it could fit nicely in the same aspect
 ratio as landscape images, creating a nice flow to the image sizes.

 Again: there will only ever be one image output at `$attachment_size` in
 `image.php`, so there will be no other images for the attachment image to
 "flow" with.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25524#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software