[wp-trac] [WordPress Trac] #25667: Missing i18n on automatic upgrade notification email

WordPress Trac noreply at wordpress.org
Wed Nov 20 02:06:42 UTC 2013


#25667: Missing i18n on automatic upgrade notification email
-------------------------+--------------------
 Reporter:  Nao          |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  3.8
Component:  I18N         |     Version:  trunk
 Severity:  minor        |  Resolution:
 Keywords:  2nd-opinion  |
-------------------------+--------------------
Changes (by dd32):

 * keywords:  has-patch => 2nd-opinion


Comment:

 Added some extra strings that were missed in the patch, and had this ugly
 one to translate:

 {{{
 /* translators: %s singular/plural form of 'plugin', 'theme', or,
 'translation' */
 $body[] = sprintf( __( 'The following %ss were successfully updated:' ),
 $type );
 }}}

 obviously this is not ideal, as we shouldn't be inserting it into the
 string like this.. however, without having 3 separate strings (by 2) with
 `_n()` I couldn't see a better way around it.

 Can we just leave it as-is as it's for development-only installs, or
 should we fix that by including all permutations of the string?
 Personally, I'd just translate it as a generic static "Items" text, or
 include "plugin" in brackets or something.. but I'm not a translator :)

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25667#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list