[wp-trac] [WordPress Trac] #25784: shortcode.js needs unit tests

WordPress Trac noreply at wordpress.org
Fri Nov 15 19:41:38 UTC 2013


#25784: shortcode.js needs unit tests
-------------------------+--------------------
 Reporter:  iandunn      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  3.8
Component:  Unit Tests   |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+--------------------
Changes (by jorbin):

 * milestone:  Awaiting Review => 3.8


Comment:

 Great start Iandunn!


 I cleaned the file up a bit based on our new jshnit standards (which were
 added after your initial patch).

 I also divided the assertions up a bit more.  I think it's better to have
 more tests with a few direct assertions than tests with a lot of
 assertions.  It makes it much easier to track down specific regressions.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25784#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list