[wp-trac] [WordPress Trac] #20124: Smilies Fail Combinations

[WordPress Trac]

#20124: Smilies Fail Combinations
--------------------------+------------------------------
 Reporter:  soulseekah    |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Formatting    |     Version:  3.3.1
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------

Comment (by mdbitz):

 == Cleanup of Pending Smilies tickets with fixes ==

 Hi, I was reviewing the pending tickets concerning the Smilies formatting
 functionality and have attached enhanced unit tests to cover the various
 scenarios as well as a patch that includes all changes outlined by the
 different tickets.

 * smilies-unittests.diff -> Rewrite of Unit Tests to split up test
 conditions, include data providers and test cases for tickets #16448,
 #20124 and #25303
 * smilies-unit-tests.out -> output of running unit tests against trunk
 (revision 26048)

 * smilies-patch.diff -> diff of all changes to formatting, functions and
 unit tests as outlined by the tickets
 * smilies-diff.out -> output of running unit tests against patch

 == Overview of Included Fixes ==

 Using the function.php.3.diff in the code resolved both #20124 and #25303.
 However the new logic adds an additional single whitespace after smilies.
 I don't think this will be a concern as when rendered to browser it gets
 shown as a single space.

 I've included the changes from #16448 with modification so that pre, code,
 script, style and textarea blocks are ignored for smilie translation. This
 aligns with logic being used in wpautop.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/20124#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software