[wp-trac] [WordPress Trac] #25864: jshint shouldn't throw errors - wp-admin/revisions.js

WordPress Trac noreply at wordpress.org
Thu Nov 7 16:21:36 UTC 2013


#25864: jshint shouldn't throw errors - wp-admin/revisions.js
-----------------------------+-----------------------------
 Reporter:  adamsilverstein  |      Owner:
     Type:  enhancement      |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  Unit Tests       |    Version:  trunk
 Severity:  normal           |   Keywords:  has-patch
-----------------------------+-----------------------------
 The file wp-admin/revisions.js throws many errors in the jshint section of
 the build process.

 The errors generated are:

 W116: Expected '{' and instead saw ... - thrown in the many places where
 curly brackets are omitted from single line if/else blocks

 W081: Too many var statements. - thrown in several places where var is
 used separately in a single function block instead of being combined into
 a single var statement at the top of the function

 W117: ? is not defined. (Backbone, '_' Underscore, _wpRevisionsSettings)
 thrown for variables that are defined/passed from external sources; also
 several spots where var declaration missing ahead of variable use

 W098: ? is defined but never used. - thrown where function signatures
 include variables that are never used and are therefore not needed

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25864>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list