[wp-trac] [WordPress Trac] #23050: make_clickable incorrectly formats anchors with URL's and spaces in them in comments

WordPress Trac noreply at wordpress.org
Sun Nov 3 12:56:39 UTC 2013


#23050: make_clickable incorrectly formats anchors with URL's and spaces in them in
comments
-----------------------------+------------------------------
 Reporter:  johnjamesjacoby  |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  Awaiting Review
Component:  Formatting       |     Version:  3.4.2
 Severity:  normal           |  Resolution:
 Keywords:  needs-patch      |
-----------------------------+------------------------------

Comment (by mikejolley):

 @netweb Personally I would expect existing links to be left alone. The
 code patched was to fix links within links, the links within links being
 the invalid ones (which would have nofollow).

 Entire string could, after fixing, be ran though something like
 wp_rel_nofollow which is also in the formatting.php file, but I'm not sure
 if this is the expected behaviour or not - the function is make_clickable,
 and makes no mention of formatting links with nofollow.

 In fact, in the case of comments where nofollow is important, the content
 would have already been nofollowed during the pre_comment_content hook.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/23050#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list